-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5816] S3 to snowflake operator #6469
[AIRFLOW-5816] S3 to snowflake operator #6469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6469 /- ##
=========================================
Coverage ? 85.17%
=========================================
Files ? 756
Lines ? 39721
Branches ? 0
=========================================
Hits ? 33832
Misses ? 5889
Partials ? 0
Continue to review full report at Codecov.
|
FYI duplicated Jira https://issues.apache.org/jira/browse/AIRFLOW-3031 |
@OmerJog can you give a pull request for this? |
@shaikshakeel it's just a note for committers to close handle the duplicate jira. @feluelle can you review? |
…nowflake_operator # Conflicts: # docs/operators-and-hooks-ref.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for new modules we should directly follow AIP-21 and place the operator directly into the providers package providers/snowflake
.
In case of transfer operators where two providers are involved, the transfer operators will be moved to
"source"(NOTE it's been changed to "target" in subsequent Update) of the transfer. When there is only one provider as target but source is a database or another non-provider source, the operator is put to the target provider.
Hi @feluelle Is the below path is okay?
|
@feluelle This is S3 to snowflake so it should be |
@feluelle can you confirm this? |
I think it belongs to the
So
is correct imo. |
Hello. I missed that one. Sorry. Yes it should be snowflake ( the operator) hooks should be in s3/snowflake. |
…nowflake_operator # Conflicts: # scripts/ci/pylint_todo.txt
Co-Authored-By: Felix Uellendall <[email protected]>
…nowflake_operator
Co-Authored-By: Felix Uellendall <[email protected]>
- move Snowflake from contrib to providers - fix pylint issues Co-authored-by: Felix Uellendall <[email protected]>
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation