Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code in SnowflakeHook #20107

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Remove unused code in SnowflakeHook #20107

merged 1 commit into from
Dec 8, 2021

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 7, 2021

Method _get_aws_credentials uses variables before they are defined, and in addition, I don't see any references to that method. Fortunately, this method was marked private so we can safely remove it.

$ grep -R -i '_get_aws_credentials' airflow/ tests/
Binary file airflow//providers/snowflake/hooks/__pycache__/snowflake.cpython-38.pyc matches
airflow//providers/snowflake/hooks/snowflake.py:    def _get_aws_credentials(self) -> Tuple[Optional[Any], Optional[Any]]:

CC: @mattpolzin @harishkrao @sfc-gh-turbaszek

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:snowflake Issues related to Snowflake provider labels Dec 7, 2021
eladkal
eladkal approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #3150 without actually being used.
The snowflake.rst suggest it was used in S3ToSnowflakeOperator but reviewing the PR which added the operator also doesn't use it #6469

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 7, 2021
@potiuk
Copy link
Member

potiuk commented Dec 7, 2021

Docs failing.

@mik-laj mik-laj merged commit 7fb301b into apache:main Dec 8, 2021
@potiuk potiuk mentioned this pull request Dec 31, 2021
Closed
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbaszek turbaszek turbaszek approved these changes

@eladkal eladkal eladkal approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

Assignees
No one assigned
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:snowflake Issues related to Snowflake provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mik-laj @potiuk @turbaszek @eladkal