Remove all deprecation warnings in providers #17900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
provider:cncf-kubernetes
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
2 times, most recently
from
a6f7f87
to
6e9435b
Compare
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
from
6e9435b
to
5a9d79b
Compare
potiuk
changed the title
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
from
5a9d79b
to
bd34146
Compare
|
I'd love to merge that one before releasing the new wave of providers #17890, this way all examples and code will be "warning-free". We had many deprecation warnings generated either in examples or when simply importing the providers. This will prevent it from happening also in the future as is checked in the CI. |
|
I don’t understand the Big Query stuff; everything else LGTM. |
eladkal
approved these changes
Aug 30, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
from
bd34146
to
e830171
Compare
mik-laj
reviewed
Aug 30, 2021
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
from
e830171
to
e4561b8
Compare
There were a number of deprecation warnings when just importing certain providers or their examples. Some of them came from still using 1.10 classes, some from using still `apply_defaults` and some from badly implemented fallback mechanism to support backwards compatibility. This has all been fixed and our documentation generation step for providers in CI will also fail in case there are some new DeprecationWarnings generated, which means that they will have to be fixed before merging. While checking that we found that BigQuery table_resource new approach had some inconsistencies when passing new `table_resource` parameters. Some deprecated parameters should be None by default, otherwise you'd have to explicitly set them to None when `table_resource` is set but when it is not set, the backwards compatible behaviour is maintained - the parameters get the same. default values set. Several deprecation warnings had wrong stack-level - this has been fixed as well. The "legitimate" warnings are now filtered out and they are only filtered out for the appropriate modules we know they are generated from or in case the warnings result from direct import of the deprecated module.
potiuk
force-pushed
the
cleanup-warnings-from-providers
branch
from
e4561b8
to
27b1991
Compare
mik-laj
approved these changes
Aug 30, 2021
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of deprecation warnings when just importing
certain providers or their examples. Some of them came from still
using 1.10 classes, some from using still
apply_defaultsandsome from badly implemented fallback mechanism to support
backwards compatibility.
This has all been fixed and our documentation generation step
for providers in CI will also fail in case there are some new
DeprecationWarnings generated, which means that they will have
to be fixed before merging.
While checking that we found that BigQuery table_resource new
approach had some inconsistencies when passing new
table_resourceparameters. Some deprecated parameters should be None by default,
otherwise you'd have to explicitly set them to None when
table_resourceis set but when it is not set, the backwardscompatible behaviour is maintained - the parameters get the same.
default values set.
Several deprecation warnings had wrong stack-level - this has been
fixed as well.
The "legitimate" warnings are now filtered out and they are only
filtered out for the appropriate modules we know they are generated
from or in case the warnings result from direct import of the
deprecated module.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.