-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for scss files #35
Comments
I’ve submitted a pull request with support for SCSS files. If you can, clone my test branch and let me know if you find anything that’s not working as expected. In its current state, scss-syntax sets the file type of SCSS files to |
Is this issue solved? When I open a scss file I don't get the syntax highlighting. Setting ft to css or sass fixes that. |
I’m afraid the issue remains open, just as its status indicates. This is mostly because I do not myself use SCSS (yet, at least – but I’ve intended to give it a spin for a while and never yet got around to it), don’t have a plugin for SCSS installed, and so I have no idea what this business about the value of the I’ve been meaning to sit down and survey the situation so I can evaluate the patches I’ve been given (I admit I have not been a good stewart in this respect), but… it never quite rises near enough the top on my list of priorities to be noticed, so this here issue has been stalled for far longer than it should have. If someone wants to do my homework for me and tell me what the situation looks like overall and how it needs addressing overall (rather than just throw a patch over the wall – not that that isn’t appreciated! but I will be maintaining it afterwards so I need to understand why I’m making a change I’m making), I would be oh so grateful. |
I apologize for not replying sooner. Thank you for keeping the issue open for so long. As far as I know, scss-syntax.vim is the only SCSS syntax plugin for vim. I submitted a pull request to change the default filetype to There are a few other SCSS related vim plugins that I know of, including vim-syntastic-scss-lint and scss-snippets. Both of these use To find out whether There might be cases when you would like the filetype to be My conclusion and opinion is that |
Thanks. Absolutely no apologies necessary; also, of course I’m not going to close an issue before it’s resolved. If any apologies are needed they are mine – I have been putting off dealing with this issue because it would be tedious work for me… so thank you muchly for doing all the legwork for me. It’ll take me a day or two to get to this, but I’ll be getting back to you soon. |
Is there anything else I can do to help you get closer to a decision? :) |
Hrmf. Actually that is not the only SCSS syntax plugin (even if it’s the only one on GitHub): Vim actually ships with a SASS SCSS syntax by @tpope, and the highlight groups in that one have different names. Now, I have added the But I can’t get the scss-syntax.vim plugin to load instead of the stock one. I’d have to do that in order to test that it’ll work with either. (If I can’t figure out a better way I’ll just move Vim’s own files out of the way temporarily. But surely there’s a better way?) Anyway, I’ve pushed an If this works out I’ll ship it whether or not I’ve found a way to test it. |
I was not aware of the stock Sass SCSS syntax plugin. A newer version of the plugin is available here on GitHub (tpope/vim-haml), and it appears that the SCSS syntax is identical to the Sass syntax, with the exception of comments (multi and single line) being placed in the Anyways, I examined the highlight groups both with and without scss-syntax.vim from @cakebaker, and here are the results:
All colors are highlighted, and never with both I’m using Vundle to load plugins (planning to move to vim-plug), and judging by the test results, the scss-syntax.vim plugin is loaded instead of the stock one. I hope this helps! |
Thanks! I’m a little embarrassed at the effort you went to at my behest. Particularly because, d’oh: I’m not using any of the known plugin managers, I’ve just got my own custom bundle loader (a stripped-down version of unbundle), which inserts the bundle paths after Vim’s paths in Sooo… I’ve (finally) been able to test this for myself and yes it works. So now it’s shipped. Thank you for your interminable patience. |
Most hex values and rgba values are not colored in For example, the rgba here are not colored
but it is colored when changing it to:
The file is saved as |
vim-css-color
doesnt initialize inscss
files when scss-syntax is installed.The text was updated successfully, but these errors were encountered: