Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark-smoky style #3835

Closed

Conversation

MaksimSazanovich
Copy link

No description provided.

Copy link

vercel bot commented Jul 2, 2024

@MaksimSazanovich is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up 👍 emojis (see #1935). We expect to see at least 10-15 thumbs up before making a decision to merge your pull request into the master branch. Remember that you can also support themes of other contributors that you liked to speed up their merge.

Warning

Please do not submit a pull request with a batch of themes, since it will be hard to judge how the community will react to each of them. We will only merge one theme per pull request. If you have several themes, please submit a separate pull request for each of them. Situations when you have several versions of the same theme (e.g. light and dark) are an exception to this rule.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

❌ Theme PR does not adhere to our guidelines.

Test results

  • ❌ dark-smoky

Result: ❌ Some themes are invalid.

Unfortunately, your theme PR contains an error or does not adhere to our theme guidelines. Please fix the issues below, and we will review your
PR again. This pull request will automatically close in 20 days if no changes are made. After this time, you must re-open the PR for it to be reviewed.

Details

Dark-smoky theme preview

  • ⚠️ Theme name isn't in snake_case.

  • ❌ Theme color property title_color should not start with '#'.

  • ❌ Theme color property icon_color should not start with '#'.

  • ❌ Theme color property text_color should not start with '#'.

  • ❌ Theme color property bg_color should not start with '#'.

  • ❌ Theme color property border_color should not start with '#'.

❌ Cannot create theme preview.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Jul 2, 2024
Copy link

@Jay-Karia Jay-Karia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove '#'s from color declaration strings.

It should look like this:
title_color: "edf5e1"
and so on...

Copy link
Contributor

This theme PR has been automatically closed due to inactivity. Please reopen it if you want to continue working on it.
Thank you for your contributions.

@github-actions github-actions bot closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid The bug/issue caused by minor mistakes. themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants