Fix race condition during actor startup sequence #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed race condition on actor startup sequence
|
@troygilman0 Thanks for this! Very good work. |
anthdm
requested changes
Jun 23, 2024
|
@anthdm please review |
dmitrorezn
approved these changes
Aug 5, 2024
anthdm
approved these changes
Aug 18, 2024
|
@tprifti Can your add your review as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the issue #159.
The race condition occurs when a msg is sent to an actor while it is still processing the actor.Initialized or actor.Started msg. This can easily happen when loading some state from a db when processing one of these startup msgs.
I am proposing that the inbox only be started after the actor has processed all the startup msgs. This requires some changes to the inbox:
I have added a test case to test the proper ordering of msgs under this scenario.