Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize HTTP client #139

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Add the ability to customize HTTP client #139

merged 1 commit into from
Dec 27, 2023

Conversation

antham
Copy link
Owner

@antham antham commented Dec 27, 2023

  • Add proxy feature
  • Add request timeout setting
  • Add user agent setting

@antham antham marked this pull request as ready for review December 27, 2023 12:39
* Add proxy feature
* Add request timeout setting
* Add user agent setting
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1935906) 85.36% compared to head (72352dd) 85.44%.
Report is 3 commits behind head on master.

Files Patch % Lines
internal/client/client.go 88.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   85.36%   85.44%   +0.08%     
==========================================
  Files          14       14              
  Lines         608      639      +31     
==========================================
+ Hits          519      546      +27     
- Misses         60       62       +2     
- Partials       29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antham antham merged commit 7de8fdf into master Dec 27, 2023
4 checks passed
@antham antham deleted the add-proxy-url branch December 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant