Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): LightFilter support footer (#2794) #2884

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

DerrickTel
Copy link
Contributor

close #2794

@github-actions
Copy link

github-actions bot commented May 31, 2021

🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-2884.surge.sh

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2884 (5192817) into master (054d1cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2884    /-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         173      173           
  Lines        5276     5281     5     
  Branches     1887     1889     2     
=======================================
  Hits         5227     5232     5     
  Misses         48       48           
  Partials        1        1           
Impacted Files Coverage Δ
packages/form/src/layouts/LightFilter/index.tsx 98.78% <ø> (ø)
packages/form/src/BaseForm/LightWrapper/index.tsx 90.32% <100.00%> ( 0.32%) ⬆️
...ages/utils/src/components/DropdownFooter/index.tsx 100.00% <100.00%> (ø)
...ages/utils/src/components/FilterDropdown/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054d1cf...5192817. Read the comment docs.

@chenshuai2144
Copy link
Contributor

文档好像没更新

@DerrickTel
Copy link
Contributor Author

哈哈哈哈,是的。这地铁上。等回到家了改一下

@chenshuai2144 chenshuai2144 merged commit 042daa6 into ant-design:master Jun 1, 2021
@DerrickTel DerrickTel deleted the feat-queryFilter-footer branch June 2, 2021 07:03
@unbyte
Copy link

unbyte commented Jul 15, 2021

There are no src directory in released packages, so import statements like import type { FooterRender } from '@ant-design/pro-form/src/interface'; in @ant-design/pro-utils prevents users from building projects successfully.

@DerrickTel
/cc @chenshuai2144

@giscafer
Copy link

建议 隐藏 footerRender={false} 时,自动绑定 enter 事件,回显内容。demo 也是 隐藏了确定按钮,输入文本就没法操作了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👑 [需求]如何自定义或增加query-filter轻量筛选弹出输入项的footer内容?
4 participants