fix(form): fix SchemaForm title function #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-2826.surge.sh
|
Codecov Report
@@ Coverage Diff @@
## master #2826 /- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 173 173
Lines 5277 5278 1
Branches 1894 1895 1
=======================================
Hits 5228 5229 1
Misses 48 48
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改了title function， 使其和文档、table columns定义一致
提交后的title ， 跟table columns 比，缺少默认使用
<LabelIconTip label={title} tooltip={item.tooltip || item.tip} />这个最好是，直接调用table里的
renderColumnsTitle方法， 但这样包之间就多了依赖，也可以把renderColumnsTitle放到pro-utils。 我对代码还是不太熟悉， 只能提一下自己看到的。