Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RadioGroup"s cloneElement to context #5453

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Mar 23, 2017

Close #5443

@mention-bot
Copy link

@yesmeck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afc163, @waywardmonkeys and @plandem to be potential reviewers.

@yesmeck yesmeck force-pushed the radio-group-context branch from e25b6a0 to ad7bc36 Compare March 23, 2017 08:34
@yesmeck
Copy link
Member Author

yesmeck commented Mar 23, 2017

Should we treat this change as a feature?

@codecov
Copy link

codecov bot commented Mar 23, 2017

Codecov Report

Merging #5453 into master will increase coverage by 0.05%.
The diff coverage is 91.3%.

@@            Coverage Diff             @@
##           master    #5453      +/-   ##
==========================================
+ Coverage   85.98%   86.03%   +0.05%     
==========================================
  Files         166      166              
  Lines        4394     4405      +11     
  Branches     1274     1281       +7     
==========================================
+ Hits         3778     3790      +12     
+ Misses        616      615       -1
Impacted Files Coverage Δ
components/radio/radio.tsx 100% <100%> (ø) ⬆️
components/radio/radioButton.tsx 100% <100%> (ø) ⬆️
components/radio/group.tsx 92.3% <81.81%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e5cd3...12b2eaa. Read the comment docs.

@yesmeck yesmeck force-pushed the radio-group-context branch from ad7bc36 to 12b2eaa Compare March 23, 2017 08:57
@benjycui benjycui merged commit ab6e521 into master Mar 23, 2017
@benjycui benjycui deleted the radio-group-context branch March 23, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants