-
-
Notifications
You must be signed in to change notification settings - Fork 50.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat spin wrapper className. #5425
Conversation
@aaronplanell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RaoHai, @afc163 and @benjycui to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## feature-2.9 #5425 /- ##
===============================================
Coverage 82.61% 85.99% 3.37%
===============================================
Files 166 166
Lines 4401 4404 3
Branches 1277 1278 1
===============================================
Hits 3636 3787 151
Misses 765 617 -148
Continue to review full report at Codecov.
|
😅 |
I think you forget add this new feature in the documentation of the release 2.8.3:
Best regards! |
It is a feature at 2.9 |
Ooops! Well, I think is currently released. At least you can find the improvement in master: 😮 |
Not published yet. |
Perfect! I thought that how the improvement was released in the |
In fact,... I don't see the branch |
Yes, it is going to be published soon, at there couple of days. |
You should check the released tag for released features: https://github.com/ant-design/ant-design/tree/2.8.3 |
Hello,
Add a div wrapper to the Animation component of the Spin. This div has a property className that can be setted in the Spin component.
Take a look to the previous rejected pull requests #5315 & #5318 for more information ( @afc163, @osala-netquest & @benjycui ).
Best regards.