This repository has been archived by the owner on May 20, 2024. It is now read-only.
Encode native strings to avoid errors when encountering non-ASCII characters #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode strings to bytes in order to avoid encoding errers. Change to writing files in binary mode to make code Python 2/3 compatible. Remove debugging statements Use to_bytes to encode text.
|
Looks good. 1 |
samdoran
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1144 /- ##
=======================================
Coverage 32.77% 32.77%
=======================================
Files 48 48
Lines 9264 9264
=======================================
Hits 3036 3036
Misses 6228 6228 |
samdoran
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142
Use
to_bytes()to encode native strings to avoidUnicodeDecoeErrorwhen encountering a non-ASCII character.Write files in binary mode for Python 2/3 portability.