Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(docs-infra): fix markdown link rendering #57377

Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): fix markdown link rendering #57377

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 13, 2024 •
edited
Loading

@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 13, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 13, 2024
@github-actions GitHub Actions
Copy link

Deployed adev-preview for d705973 to: https://ng-dev-previews-fw--pr-angular-angular-57377-adev-prev-kd7fpzh7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Aug 13, 2024
bencodezen
bencodezen approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal job with this fix! Nice to know we have more granular control at the rendering level. Appreciate it!

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 9857570.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@JeanMeche @AndrewKushnir
docs(docs-infra): fix markdown link rendering (#57377)
e50d239 
fixes #57376

PR Close #57377
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@JeanMeche @AndrewKushnir
docs(docs-infra): fix markdown link rendering (#57377)
95af661 
fixes #57376

PR Close #57377
@AndrewKushnir
Copy link
Contributor

@JeanMeche it looks like there is a legit CI failure in 18.1.x branch:
https://github.com/angular/angular/actions/runs/10378387531/job/28734549996

Should we revert the change in that branch?

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Aug 13, 2024
@AndrewKushnir
Revert "docs(docs-infra): fix markdown link rendering (angular#57377)"
12a8491 
This reverts commit 95af661.

Reason for revert: failign CI on 18.1.x branch.
@AndrewKushnir
Copy link
Contributor

Reverting from 18.1.x via #57380.

AndrewKushnir added a commit that referenced this pull request Aug 14, 2024
@AndrewKushnir
Revert "docs(docs-infra): fix markdown link rendering (#57377)" (#57380)
bf3235c 
This reverts commit 95af661.

Reason for revert: failign CI on 18.1.x branch.

PR Close #57380
@UziTech UziTech mentioned this pull request Aug 14, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2024
and-oli pushed a commit to and-oli/angular that referenced this pull request Sep 30, 2024
@JeanMeche @and-oli
docs(docs-infra): fix markdown link rendering (angular#57377)
6c2dd01 
fixes angular#57376

PR Close angular#57377
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bencodezen bencodezen bencodezen approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Markdown parser incorrectly parses elements in links
3 participants
@JeanMeche @AndrewKushnir @bencodezen