Make the AlbumArt icon a symbolic icon #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vixalien
commented
Mar 31, 2024
vixalien
commented
| Before | After |
|---|---|
|
Nice one, thanks! |
|
On a slightly unrelated note, wouldn't it be better to show the icon as the one shown by gnome-shell?
|
|
I guess if the assumption is that it will always be music. I went for a more generic icon, since it's about 50/50 for me. |
Ah, I'd say the beamed note more represents music/audio, while the current one would more represent streaming or radio. |
|
Yeah, there's this one:
But that kind screams early-00's media player 😅 I guess I'd be okay using what GNOME Shell uses, unless there's a better one or we can trick a designer into making one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.