Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Use Player instead of MediaController in the MediaNotificationManager #58

Open
h6ah4i opened this issue Mar 20, 2022 · 1 comment
Open

[Suggestion] Use Player instead of MediaController in the MediaNotificationManager #58

h6ah4i opened this issue Mar 20, 2022 · 1 comment
Assignees
@marcbaechinger
Labels
enhancement

Comments

@h6ah4i
Copy link
Contributor

h6ah4i commented Mar 20, 2022

I'm facing a performance problem related to #57.

MediaNotificationManager creates MediaController internally and its overhead is huge and cannot be ignored.
I think bypassing MediaController can work as a mitigation of the performance issue. What do you think?
@marcbaechinger
Copy link
Contributor

We should consider looking into this and avoid binder calls internally. This would basically mean to listen to a Player.Listener directly and then being notified about disconnection/custom layout changes in other ways.

I don't think this will happen soon though and I also don't think that the bench mark is the 10_000 media item example. We should have other indications for this not being performant enough before adding too much effort into this.

Keeping as a enhancement for now. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcbaechinger marcbaechinger

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcbaechinger @h6ah4i