-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'resize mode' toggle to PlayerControlView #228
Comments
I believe that exposing a user-facing button to change the resize mode serves a pretty niche use-case (compared to toggling the repeat mode). It's also likely to be hard to disambguate it visually from a full-screen button (which I suspect is a much more common need) - i.e. what icon would you use? I think we're unlikely to do this, but I'll leave this open in case it gets further support. Our UI components are not designed to serve every possible use-case, they're intended to work for common playback scenarios and serve as the starting point for people to implement their own UIs that can be customised to their needs (possibly by forking our components): https://exoplayer.dev/ui-components.html#further-customization |
fair enough.. with respect to icons that could be used for this particular feature (ie: resize modes).. |
a little off-topic.. I recently added the ability to my player for the user to dynamically change this mode..
|
The layout for PlayerControlView already includes an ImageButton to cycle through values in PlayerView.setRepeatToggleModes(int) .. passing each to Player.setRepeatMode(int); this UI is enabled by default.
I would request that, similarly, an ImageButton be added to this layout.. to cycle through the constant values in AspectRatioFrameLayout.. passing each to PlayerView.setResizeMode(int).
The text was updated successfully, but these errors were encountered: