Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google DAI HLS] Playback is crashed at the ImaServerSideAdInsertionMediaSource #1520

Open
1 task
devno44 opened this issue Jul 2, 2024 · 6 comments
Open
1 task

[Google DAI HLS] Playback is crashed at the ImaServerSideAdInsertionMediaSource #1520

devno44 opened this issue Jul 2, 2024 · 6 comments
Assignees
@marcbaechinger
Labels
bug needs triage

Comments

@devno44
Copy link

devno44 commented Jul 2, 2024 •
edited
Loading

Version

Media3 1.3.1

More version details

No response

Devices that reproduce the issue

All devices

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Play the SSAI content (Google DAI HLS protocol)
  2. While playing the content, when the Ad is played App is crashed.

Expected result

App is not crashed

Actual result

Playback crashes with the following stack trace:

Process: com.xx.qa, PID: 14899 java.lang.IllegalArgumentException
      at androidx.media3.common.util.Assertions.checkArgument(Assertions.java:40)
      at androidx.media3.exoplayer.source.ads.ServerSideAdInsertionMediaSource.setAdPlaybackStates(ServerSideAdInsertionMediaSource.java:179)
      at androidx.media3.exoplayer.ima.ImaServerSideAdInsertionMediaSource.invalidateServerSideAdInsertionAdPlaybackState(ImaServerSideAdInsertionMediaSource.java:790)
      at androidx.media3.exoplayer.ima.ImaServerSideAdInsertionMediaSource.setAdPlaybackState(ImaServerSideAdInsertionMediaSource.java:749)
      at androidx.media3.exoplayer.ima.ImaServerSideAdInsertionMediaSource.access$2300(ImaServerSideAdInsertionMediaSource.java:116)
      at androidx.media3.exoplayer.ima.ImaServerSideAdInsertionMediaSource$SinglePeriodLiveAdEventListener.onAdEvent(ImaServerSideAdInsertionMediaSource.java:1491)
      at androidx.media3.exoplayer.ima.ImaServerSideAdInsertionMediaSource$ComponentListener.onAdEvent(ImaServerSideAdInsertionMediaSource.java:1017)
      at com.google.ads.interactivemedia.v3.impl.zzab.zzb(com.google.ads.interactivemedia.v3:interactivemedia@@3.31.0:25)
      at com.google.ads.interactivemedia.v3.impl.zzbr.zzb(com.google.ads.interactivemedia.v3:interactivemedia@@3.31.0:12)
      at com.google.ads.interactivemedia.v3.impl.zzau.zzl(com.google.ads.interactivemedia.v3:interactivemedia@@3.31.0:50)
      at com.google.ads.interactivemedia.v3.impl.zzbb.zzf(com.google.ads.interactivemedia.v3:interactivemedia@@3.31.0:7)
      at com.google.ads.interactivemedia.v3.impl.zzax.onPostMessage(com.google.ads.interactivemedia.v3:interactivemedia@@3.31.0:2)
      at androidx.webkit.internal.WebMessageListenerAdapter.onPostMessage(WebMessageListenerAdapter.java:55)
      at java.lang.reflect.Method.invoke(Native Method)
      at org.chromium.support_lib_boundary.util.BoundaryInterfaceReflectionUtil$InvocationHandlerWithDelegateGetter.invoke(BoundaryInterfaceReflectionUtil.java:162)
      at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
      at $Proxy13.onPostMessage(Unknown Source)
      at WV.sR.a(chromium-TrichromeWebViewGoogle.aab-stable-647807130:77)
      at WV.hY.run(chromium-TrichromeWebViewGoogle.aab-stable-647807130:28)
      at android.os.Handler.handleCallback(Handler.java:938)
      at android.os.Handler.dispatchMessage(Handler.java:99)
      at android.os.Looper.loopOnce(Looper.java:201)
      at android.os.Looper.loop(Looper.java:288)
      at android.app.ActivityThread.main(ActivityThread.java:7839)
      at java.lang.reflect.Method.invoke(Native Method)
      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Media

Not applicable

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.
@devno44
Copy link
Author

devno44 commented Jul 2, 2024 •
edited
Loading

This error doesn't happen all the time, it only happens occasionally when the Ad is played, and will probably be difficult to reproduce.
Therefore, is there any way to avoid the app crashing after this error occurs? For example, using try-catch?

@devno44 devno44 changed the title [Bug] [Google DAI HLS] Playback is crashed at the ImaServerSideAdInsertionMediaSource [Google DAI HLS] Playback is crashed at the ImaServerSideAdInsertionMediaSource Jul 2, 2024
@marcbaechinger marcbaechinger self-assigned this Jul 2, 2024
@marcbaechinger
Copy link
Contributor

marcbaechinger commented Jul 2, 2024 •
edited
Loading

Can you provide us with an assetKey to test and repro with?

@devno44
Copy link
Author

devno44 commented Jul 3, 2024

@marcbaechinger
Like I said before, I'm not sure how it's reproduced, it doesn't happen often, it happens occasionally, and it's not always reproducible.
This crash is also reported a lot on firebase from our users, but we don't know how to investigate what the cause is.

@marcbaechinger
Copy link
Contributor

Thanks for your response. I understand it doesn't repro easily but without having a stream that is producing the problem, it is hard for me to do something.

An assetKey of a stream that produces the problem would make this issue actionable for me. If you're unable to share test content publicly, please send them to [email protected] using a subject in the format "Issue #1520". Please also update this issue to indicate you’ve done this.

@devno44
Copy link
Author

devno44 commented Jul 11, 2024

@marcbaechinger
Thank you, I will discuss with my team about creating a content for testing.
But before that, is there any solution that can avoid that error? At least it won't cause the app to crash ?

@devno44 devno44 mentioned this issue Jul 11, 2024
Open
@marcbaechinger
Copy link
Contributor

Therefore, is there any way to avoid the app crashing after this error occurs? For example, using try-catch?

I don't think so. The assertion is set at the place where the problem starts. If we catch it there, it would crash some later without us knowing exactly where it started.

We'll look into this when we have the media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcbaechinger marcbaechinger

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcbaechinger @google-oss-bot @devno44