Hi @mikekudzin, thanks for writing in.

just to make sure I understand the setup, are you saying in (1) you used overlays and in (2) you didn't use overlays at all?

Since you didn't see it in 1.3.1 I figure it could have some involvment to with the way we process color changing. Using the code in #1050 (comment) may help your case

In addition I see there are some artefacts around the borders of your image. @ychaparov does any of the recent work you've done around improving sampling help with this?

Not really, we haven't made improvements to resampling of 45-degree rotated videos yet.

The original image bitmap overlay is not aligned with the no. 1 output -- the text is a bit scaled and rotated even though both images have resolution 1080x1920.
I don't think BitmapOverlay causes this image modification.

@mikekudzin can you share your bitmap-reading code?
How did you create overlayBitmap used in

    val bitmapOverlayWithText = BitmapOverlay.createStaticBitmapOverlay(overlayBitmap)

@tof-tof @ychaparov I have the same problem. The version is 1.4.0-beta01. The device I'm using is Samsung S21. I've tried the suggestion in the #1050 comment but it does not help.

Here is the input and output resources:

• This image is added as a MediaItem

• This image is added as a BitmapOverlay

• This is a frame in an output video

 
Here is the way the overlay bitmap is created:

   val stream = context.contentResolver.openInputStream(uri)
   val bitmap = BitmapFactory.decodeStream(stream)

you should probably set some bitmap factory options like this:

    if (Util.SDK_INT >= 26) {
      options = new BitmapFactory.Options();
      options.inPreferredColorSpace = ColorSpace.get(ColorSpace.Named.SRGB);
    }

Here's how the MediaItem image BitmapFactory options will be set

@ychaparov just tried that and it stays the same as I mentioned above.

just to make sure I understand the setup, are you saying in (1) you used overlays and in (2) you didn't use overlays at all?

@tof-tof Correct.

@ychaparov here is bitmap initialisation code.

    private fun createCanvasBitmap(width: Int = D_WIDTH, height: Int = D_HEIGHT): Bitmap {
        val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888)
        return bitmap
    }

    protected fun initCanvas(width: Int = D_WIDTH, height: Int = D_HEIGHT): Pair<Canvas, Bitmap> {
        val bitmap = createCanvasBitmap(width, height)
        val canvas = Canvas(bitmap)
        return canvas to bitmap
    }

I also tried approach with the BitmapFactory

        val options = BitmapFactory.Options()
        options.inPreferredColorSpace = ColorSpace.get(ColorSpace.Named.SRGB)
        val overlayBitmap = BitmapFactory.decodeFile(overlayFile.path, options)

Still observe the issue .

@yuriikonovalov and @mikekudzin how many EditedMediaItemSequences do you have in your composition?

@droid-girl In my case, it's 3 EditedMediaItemSequences. One is for a video. Another one is a transparent image with those bitmap overlays. One more is just used to add the "a media item" image as a media item to the composition, not as a bitmap overlay so that the difference is visible.

@droid-girl I use 3 EditedMediaItemSequences: background, video with some transformations, overlay

@ychaparov figured out the problem, we will have a fix soon in main. The issue was with Composition that contains more than 1 sequence containing video/image assets.

Could you please try verify if 7103f21 fixes the issue for your use cases?

@ychaparov Just tried that, it's fixed for my case. Thanks.

Just need to set SdrWorkingColorSpace. Otherwise colors will still be a little bit off but not like it was before.

Transformer.Builder(this)
    .setVideoFrameProcessorFactory(
        DefaultVideoFrameProcessor.Factory.Builder()
            .setSdrWorkingColorSpace(
                DefaultVideoFrameProcessor.WORKING_COLOR_SPACE_ORIGINAL
            )
            .build()
    )

With setting SdrWorkingColorSpace

Without setting SdrWorkingColorSpace - here it's possible to see some difference