Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling javadoc #43

Closed

Conversation

zactestaccount
Copy link
Contributor

@zactestaccount zactestaccount commented Jul 24, 2020

Hi it's Zac from a test account!

Test: It compiles without martians invading

Hi it's Zac from a test account!
@zactestaccount
Copy link
Contributor Author

CC @dlam

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@liutikas liutikas requested a review from tikurahul July 24, 2020 00:20
@tikurahul
Copy link
Collaborator

tikurahul commented Jul 24, 2020

@zactestaccount You will need a Test stanza in the pull request body.

Something like Test: N/A.

@zactestaccount
Copy link
Contributor Author

Updated the body, is that enough to re-kick?

@dlam dlam added cla: yes and removed cla: no labels Jul 24, 2020
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@dlam dlam removed the request for review from tikurahul July 24, 2020 02:29
@tikurahul
Copy link
Collaborator

@zactestaccount
Copy link
Contributor Author

image

@tikurahul
Copy link
Collaborator

@zactestaccount your build was successful ! 🛩️

@zactestaccount zactestaccount deleted the patch-1 branch July 24, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants