Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fragment] Add lint warning for calling setOnCancelListener and setOnDismissListener in onCreateDialog() #171

Closed
wants to merge 4 commits into from
Closed

[Fragment] Add lint warning for calling setOnCancelListener and setOnDismissListener in onCreateDialog() #171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift click to select a range
b6a1858
Add lint warning for calling setOnCancelListener and setOnDismissList…
tatocaster Apr 27, 2021
196dc0c
add checks and test cases for each violation
tatocaster May 5, 2021
1d77d07
remove trailing whitespaces
tatocaster May 5, 2021
92f6ef9
fix lint issues
tatocaster May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
remove trailing whitespaces
  • Loading branch information
@tatocaster
tatocaster committed May 5, 2021
commit 1d77d071fea3ffd08f3ff88fe0388f616394fa1c
2 changes: 1 addition & 1 deletion ...ment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 53,7 @@ class OnCreateDialogIncorrectCallbackDetector : Detector(), SourceCodeScanner {
explanation = """When using a `DialogFragment`, the `setOnCancelListener` and \
`setOnDismissListener` callback functions within the `onCreateDialog` function \
__must not be used__ because the `DialogFragment` owns these callbacks. \
Instead the respective `onCancel` and `onDismiss` functions can be used to \
Instead the respective `onCancel` and `onDismiss` functions can be used to \
achieve the desired effect.""",
category = Category.CORRECTNESS,
severity = Severity.WARNING,
Expand Down
2 changes: 1 addition & 1 deletion ...-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 68,7 @@ class OnCreateDialogIncorrectCallbackDetectorTest : LintDetectorTest() {
override fun onCancel(dialog: DialogInterface) {
super.onCancel(dialog)
}

override fun onDismiss(dialog: DialogInterface) {
super.onDismiss(dialog)
}
Expand Down