-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation] Make deep link path arguments to not include slash #153
[Navigation] Make deep link path arguments to not include slash #153
Conversation
Slash is used for URI path splitting. Arguments should not include more than one path section. Test: ./gradlew test connectedCheck Fixes: b/184072811
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This breaks cases when argument needs to have a slash in it: scheme://foo/{page} page = bar/xyz So DL scheme://foo/bar/xyz doesn't work 😢 |
If you want special characters included as part of an argument, you should be encoding them via |
Merge full
…On Wed, Feb 2, 2022, 7:11 PM Damir Abdullin, ***@***.***> wrote:
This breaks cases when argument needs to have a slash in it:
scheme://foo/{page}
page = bar/xyz
So DL scheme://foo/bar/xyz doesn't work 😢
—
Reply to this email directly, view it on GitHub
<#153 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXKJHJCHNJP6GRXMXAIH76DUZEGN5ANCNFSM42KCHYEQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Proposed Changes
Slash is used for URI path splitting. Arguments should not include more than one path section.
I purpose to replace
(. ?)
with([^/] ?)
in resulting regexp.Testing
Added corresponing tests to
NavDestinationAndroidTest
Test: ./gradlew test connectedCheck
Issues Fixed
Fixes: b/184072811