Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String length too long #11

Open
xyproto opened this issue Aug 9, 2018 · 2 comments
Open

String length too long #11

xyproto opened this issue Aug 9, 2018 · 2 comments

Comments

@xyproto
Copy link
Contributor

xyproto commented Aug 9, 2018

Steps to reproduce the issue:

Run the saved user.wasm file with vmir:

$ vmir user.wasm
Parser error: src/vmir_wasm_parser.c:167 : String length too long
@andoma
Copy link
Owner

andoma commented Aug 11, 2018

Problem is the wasm_parse_section_import_decl() function which doesn't handle imported tables.

https://github.com/andoma/vmir/blob/master/src/vmir_wasm_parser.c#L275

Also it shouldn't just silently ignore kinds it can't import :-(

andoma added a commit that referenced this issue Aug 11, 2018
@andoma
wasm: Correctly bail out on kind/types we don't support
8fc7027 
Related to #11
@andoma
Copy link
Owner

andoma commented Aug 11, 2018

This commit 8fc7027 doesn't really fix anything. Just pinpoints the actual error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xyproto @andoma