-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systemd warns about unset variables #1142
Comments
@dennis-ju |
Yes, I believe that adding the line In the systemd manual (see link) under |
Systemd now gives a warning when IIOD_EXTRA_OPTS is unset. This change sets it to an empty string by default while still allowing it be overridden by /etc/default/iiod. Fixes analogdevicesinc#1142. Change-Id: I71c9979741eabab1fb5278b503bc984d998cfb3d Signed-off-by: Dennis Jusufovic <[email protected]>
Systemd now gives a warning when IIOD_EXTRA_OPTS is unset. This change sets it to an empty string by default while still allowing it be overridden by /etc/default/iiod. Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Systemd now gives a warning when IIOD_EXTRA_OPTS is unset. This change sets it to an empty string by default while still allowing it be overridden by /etc/default/iiod. Fixes #1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Is there a possibility that we could add this to the legacy branch? |
Yes |
Lets re-open |
Systemd now gives a warning when IIOD_EXTRA_OPTS is unset. This change sets it to an empty string by default while still allowing it be overridden by /etc/default/iiod. Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Systemd now gives a warning when IIOD_EXTRA_OPTS is unset. This change sets it to an empty string by default while still allowing it be overridden by /etc/default/iiod. Fixes #1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Unfortunately the issue is not solved yet. A rogue dollar sign causes the assignment of IIOD_EXTRA_OPTS to be invalid. I'll add a new fix soon. |
Fixed an invalid assignment of IIOD_EXTRA_OPTS in the service file. Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Fixed an invalid assignment of IIOD_EXTRA_OPTS in the service file. Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Removing extraneous $ in the assignment of IIOD_EXTRA_OPTS in the service file that was part of analogdevicesinc@a436ad6 Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Removing extraneous $ in the assignment of IIOD_EXTRA_OPTS in the service file that was part of analogdevicesinc@a436ad6 Fixes analogdevicesinc#1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Removing extraneous $ in the assignment of IIOD_EXTRA_OPTS in the service file that was part of a436ad6 Fixes #1142. Signed-off-by: Dennis Jusufovic <[email protected]>
Removing extraneous $ in the assignment of IIOD_EXTRA_OPTS in the service file that was part of a436ad6 Fixes #1142. Signed-off-by: Dennis Jusufovic <[email protected]>
During startup of iiod, we get the following warning:
iiod.service: Referenced but unset environment variable evaluates to an empty string: IIOD_EXTRA_OPTS
This is because since v254 of systemd, unset environmental variables will result in a warning (see commit).
I could make a PR where I add this to the service file:
Environment=IIOD_EXTRA_OPTS=''
Would this be a good solution?
The text was updated successfully, but these errors were encountered: