-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort functions by name in documentation #470
Sort functions by name in documentation #470
Conversation
c507a5b
to
768abf6
Compare
I see also a little refactoring and probably this will require that #465 to be merged before this and updated or viceversa as they are both changing the |
Depends if someone approves the PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I"ll have to test it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdwalters Tested it and it works. Found some small details that can help improve code readability!
460c612
to
831db27
Compare
831db27
to
d98f2af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn"t test it though. Can anyone test this? I"m on vacations rn
So I tested with the script on amber-lang/amber-docs#39 Tests works but:
Generates:
@hdwalters I guess that doesn"t handle very good the output parameter |
Isn"t that incorrect @Mte90 ? shouldn"t that be |
No that line is extracted from an amber script, from the PR in amber-docs about stdlib |
@Mte90 could you then provide the entire script or at least some part of that script that shows the entire context? |
It was already in the comment amber-lang/amber-docs#39 |
Fixes #460. Sorts function declarations (we expect these to be the only top level elements in the abstract syntax tree) by name. Also uses path concatenation to ensure the base directory is overwritten by an absolute output directory.