Add empty variable declaration support #432
Conversation
| let typee = parse_type(meta)?; | ||
| self.handle_add_variable(meta, &self.name.clone(), typee, tok, true)?; | ||
| self.is_declare = true; | ||
| return Ok(()); |
There was a problem hiding this comment.
Why cant we allow for this syntax?
let x: Text = fun_returning_any()
There was a problem hiding this comment.
we can, its just not relevant in this PR. you should create another issue for that
|
There was a problem hiding this comment.
This logic doesn't track different execution branches. Here's an examle:
fun test(arg: Num): Null {
let var: Text
if {
arg < 20: var = "Hello, World!"
arg > 30: var = "Hi, hello!"
}
echo var
}
test(10) // outputs "Hello, World!"
test(25) // outputs empty message, shouldn't be possible
test(40) // outputs "Hi, hello!"
Variable is being assigned only in two branches, but is always used. This means it also gets used when uninitialized.
|
so we can't actually track if its assigned in a way that would matter. i think we should remove that check for now and implement it later when we start actually analyzing code for errors. @Ph0enixKM @Mte90 what do you think |
|
It make sense what @b1ek, probably what we can do is adding a comment right in the code with |
|
I say we shouldn't implement this language feature until we can make it work as intended. There are enough workarounds for it, so this shouldn't be a problem. |
This comment was marked as off-topic.
This comment was marked as off-topic.
*offer a broken feature
This isn't about output optimization, this is about correctness and soundness of the language. Optimization is when something already works, but is made to work better. This doesn't work. |
|
Sorry I confused the PR with another one about constants... About my proposal is to do what is written here #432 (comment) |
I get that, but we don't use Mutex anywhere else in this project as we don't utilize multi threading. Why do we need it now? |
|
I agree with @mks-h. The features implemented should work as expected from the ground up. Otherwise people will start to use it in an unintended way. Thus when we introduce a fix for this issue, then it will create a breaking change. |
okay so i've implemented empty variable declarations for this syntax:
it translates like this:
let variable: Text->declare variableand if the variable was declared but never assigned, it will throw a compile time error
closes #420