Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std): math round #426

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix(std): math round #426

merged 1 commit into from
Aug 31, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Aug 30, 2024

This one works and avoid printf that has issues with the locale used.

@Mte90 Mte90 linked an issue Aug 30, 2024 that may be closed by this pull request
[BUG] printf and locales different to US #425
Closed
KrosFire
KrosFire approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@KrosFire KrosFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever. I like it

@b1ek b1ek merged commit a701b52 into amber-lang:master Aug 31, 2024
1 check passed
@Mte90 Mte90 deleted the fix-round branch September 5, 2024 13:03
Mte90 added a commit to Mte90/Amber that referenced this pull request Sep 19, 2024
@Mte90
fix(std): math round (amber-lang#426)
d9ebda2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrosFire KrosFire KrosFire approved these changes

@b1ek b1ek b1ek approved these changes

@CymDeveloppement CymDeveloppement Awaiting requested review from CymDeveloppement

@Ph0enixKM Ph0enixKM Awaiting requested review from Ph0enixKM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] printf and locales different to US
3 participants
@Mte90 @b1ek @KrosFire