-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/Bug] No stdlib comments in bash generated #408
[Feature/Bug] No stdlib comments in bash generated #408
Conversation
@@ -53,6 53,9 @@ pub fn is_functions_comment_doc(meta: &mut ParserMetadata) -> bool { | |||
return false; | |||
} | |||
} | |||
if tok.word.starts_with("#[") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this will allow to ignore comments like the function comments in stdlib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that function comments weren't detected was because in src/math
we use preprocessor directive (#[...]
) that doesn't get detected by the algorithm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the issue there was also in other stdlib stuff not just in math
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I checked this - it was everywhere were the preprocessor directive was used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing the changes on this branch, does it resolve the issues you observed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't checked if works but i saw that the comments were kept also on functions that doesn't have those attributes.
No description provided.