Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix CI #394

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix Nix CI #394

merged 2 commits into from
Aug 10, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Aug 8, 2024

The Amber code was wrong...

The Amber code was wrong...
@Mte90 Mte90 requested review from Ph0enixKM, mks-h, b1ek and KrosFire August 8, 2024 15:33
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? Is the mewline character not working properly?

.github/workflows/nix.yml Outdated Show resolved Hide resolved
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90
Copy link
Member Author

Mte90 commented Aug 9, 2024

Why is that? Is the mewline character not working properly?

just try the line with your Amber and you see that the char "\n" doesn't get converted as newline character.

@Mte90 Mte90 requested a review from Ph0enixKM August 9, 2024 08:48
@mks-h mks-h removed their request for review August 9, 2024 09:42
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ph0enixKM Ph0enixKM merged commit 8557cee into master Aug 10, 2024
@Ph0enixKM Ph0enixKM deleted the fix-nix-ci branch August 10, 2024 18:50
Mte90 added a commit to Mte90/Amber that referenced this pull request Sep 19, 2024
* Fix Nix CI

The Amber code was wrong...

* Update .github/workflows/nix.yml

Co-authored-by: Phoenix Himself <[email protected]>

---------

Co-authored-by: Phoenix Himself <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants