Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib tests from amber files v2 #266

Merged
merged 20 commits into from
Jul 4, 2024
Merged

stdlib tests from amber files v2 #266

merged 20 commits into from
Jul 4, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Jul 3, 2024

Ref: #238

I had issues with conflicts and resetting the branch closed the other PR.
Anyway I am starting from here and now I will migrate the various tests.

@Mte90 Mte90 requested review from Ph0enixKM and b1ek July 3, 2024 15:42
@Mte90
Copy link
Member Author

Mte90 commented Jul 3, 2024

The PR adds 2 different folder, one is stdlib with include a *.output.txt file for every test and another folder stdlib_no-output that is used for tests that are require rust code so there isn't any output to check.

b1ek
b1ek previously requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@b1ek b1ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why stdlib_no-output? make it consistent, like stdlib_no_output or smth

@Mte90
Copy link
Member Author

Mte90 commented Jul 4, 2024

why stdlib_no-output? make it consistent, like stdlib_no_output or smth

I was thinking to simplify more, move the folder inside stdlib and rename that one in just no_output

@Mte90 Mte90 mentioned this pull request Jul 4, 2024
Closed
@Ph0enixKM
Copy link
Member

@Mte90 Can we use tab as 4 spaces across the project? I'll create an editor config in a separate issue #269

@Mte90
Copy link
Member Author

Mte90 commented Jul 4, 2024

Ready for another review :-)

@Mte90 Mte90 requested a review from b1ek July 4, 2024 10:29
Ph0enixKM
Ph0enixKM requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some weird quirks here and there. Looking good overall

src/tests/stdlib/includes_empty_text_array.ab Outdated Show resolved Hide resolved
src/tests/stdlib/includes_empty_num_array.ab Outdated Show resolved Hide resolved
src/tests/stdlib/includes_exact_match.ab Outdated Show resolved Hide resolved
src/tests/stdlib/includes_partial_match_with_expanded_element.ab Outdated Show resolved Hide resolved
src/tests/stdlib/includes_prefix_match.ab Outdated Show resolved Hide resolved
src/tests/stdlib/join.output.txt Show resolved Hide resolved
src/tests/stdlib/load_env_file.ab Show resolved Hide resolved
src/tests/stdlib/make_executable.ab Show resolved Hide resolved
src/tests/stdlib/no_output/download.ab Outdated Show resolved Hide resolved
src/tests/stdlib/switch_user_permission.ab Outdated Show resolved Hide resolved
@CymDeveloppement
Copy link
Member

Maybe tests can be moved in std folder.
this is a first way to define package lib architecture.
for example :

- libname
  - src
  - tests
  - docs

stdlib is just like another lib

Mte90 and others added 8 commits July 4, 2024 15:10
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_empty_text_array.ab
3d86e2e 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_empty_num_array.ab
c5b5dd6 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_exact_match.ab
11d836c 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_partial_match_with_expanded_element.ab
19a0ea8 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_prefix_match.ab
af9da3d 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/join.output.txt
6e59847 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/includes_text_array.ab
f53705d 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90 @Ph0enixKM
Update src/tests/stdlib/no_output/download.ab
69fd6eb 
Co-authored-by: Phoenix Himself <[email protected]>
@Mte90

This comment was marked as off-topic.

Sign in to view
@Mte90 Mte90 requested a review from Ph0enixKM July 4, 2024 13:27
@Mte90
Copy link
Member Author

Mte90 commented Jul 4, 2024

Ready for a new review again!

@Mte90 Mte90 dismissed b1ek’s stale review July 4, 2024 13:48

already done

@CymDeveloppement

This comment was marked as off-topic.

Sign in to view
@Mte90
Copy link
Member Author

Mte90 commented Jul 4, 2024

I understand, maybe the first step is to create a test function in Amber lib.

Better move that to a new ticket :-)

Ph0enixKM
Ph0enixKM approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Mte90 Mte90 merged commit 9985f4f into amber-lang:master Jul 4, 2024
1 check passed
@Mte90 Mte90 deleted the simplify-tsts branch July 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ph0enixKM Ph0enixKM Ph0enixKM approved these changes

@CymDeveloppement CymDeveloppement CymDeveloppement approved these changes

@b1ek b1ek Awaiting requested review from b1ek

@FedericoCeratto FedericoCeratto Awaiting requested review from FedericoCeratto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mte90 @Ph0enixKM @CymDeveloppement @b1ek