Use `$(< file)` instead of `$(cat file)` #264

akihiro17 · 2024-07-02T15:19:19Z

I think it's better to use $(< file) instead of $(cat file)

ref. https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html

The command substitution $(cat file) can be replaced by the equivalent but faster $(< file).

Mte90

Tested with shellcheck and it is valid bash:

#!/usr/bin/bash

echo $(< "test")

I learned something new but it is better as it is pure bash.

Ph0enixKM

I learned something new as well! Great PR

Use $(< file) instead of $(cat file)

333598e

Mte90 self-requested a review July 2, 2024 15:25

Mte90 approved these changes Jul 2, 2024

View reviewed changes

Ph0enixKM approved these changes Jul 2, 2024

View reviewed changes

Ph0enixKM merged commit 346b90e into amber-lang:master Jul 2, 2024
1 check passed

akihiro17 deleted the redirect-instead-of-cat branch July 3, 2024 03:23

Mte90 pushed a commit to Mte90/Amber that referenced this pull request Jul 3, 2024

Use $(< file) instead of $(cat file) (amber-lang#264)

bd01fde

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `$(< file)` instead of `$(cat file)` #264

Use `$(< file)` instead of `$(cat file)` #264

akihiro17 commented Jul 2, 2024 •

edited

Loading

Mte90 left a comment

Ph0enixKM left a comment

Use $(< file) instead of $(cat file) #264

Use $(< file) instead of $(cat file) #264

Conversation

akihiro17 commented Jul 2, 2024 • edited Loading

Mte90 left a comment

Choose a reason for hiding this comment

Ph0enixKM left a comment

Choose a reason for hiding this comment

Use `$(< file)` instead of `$(cat file)` #264

Use `$(< file)` instead of `$(cat file)` #264

akihiro17 commented Jul 2, 2024 •

edited

Loading