Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move VS Code plugin to amber-lang org #86

Closed
uncenter opened this issue May 22, 2024 · 6 comments
Closed

[Feature] Move VS Code plugin to amber-lang org #86

uncenter opened this issue May 22, 2024 · 6 comments
Labels
editor enhancement New feature or request

Comments

@uncenter
Copy link
Contributor

https://github.com/Ph0enixKM/Amber-Prototype/tree/master/vsc-syntax should probably be moved here so it can be updated as well.

@Ph0enixKM Ph0enixKM added the enhancement New feature or request label May 24, 2024
@Ph0enixKM
Copy link
Member

Yeah, good idea

@Ph0enixKM Ph0enixKM changed the title Move VS Code plugin to this repository ✨ Move VS Code plugin to this repository May 25, 2024
@Ph0enixKM Ph0enixKM added this to the Amber 0.4.0-alpha milestone Jun 17, 2024
@Mte90
Copy link
Member

Mte90 commented Jun 24, 2024

I don't think otherwise this repository should be the home also for the plugin for Intellij and the other ide.
Usually there is a different repository so it can be managed alone from a mantainer point of view.

@Mte90 Mte90 added the editor label Jun 24, 2024
@Ph0enixKM Ph0enixKM changed the title ✨ Move VS Code plugin to this repository [Feature] Move VS Code plugin to this repository Jul 7, 2024
@b1ek
Copy link
Member

b1ek commented Jul 9, 2024

i think it breaks the division of labor. IDE plugins are third party tools, which are not amber team's responsibility to maintain

@uncenter
Copy link
Contributor Author

uncenter commented Jul 9, 2024

IDE plugins should almost certainly be done by the team behind the project/language. It's gone poorly every other time I can think of - having the maintainer be able to commit to the IDE support repo is key, say to make significant changes to a grammar or bring the grammar inline with the language repo itself. All the large projects I can think of maintain their IDE plugins themselves - be it Astro, Deno, Vitest, Bun, etc. And the maintainer of Amber already maintains the existing extension so it doesn't really make sense to take it away from them lol.

@uncenter uncenter changed the title [Feature] Move VS Code plugin to this repository [Feature] Move VS Code plugin to amber-lang org Jul 9, 2024
@Ph0enixKM
Copy link
Member

I'd just move this plugin to a separate repo where all the plugins are stored. @Mte90 @b1ek you don't have to worry about maintaining it. The community will or maybe other people that know how to maintain these. I'm open for that as IDE plugins are crucial for a good DX.

@Ph0enixKM
Copy link
Member

This issue has been resolved:

https://github.com/amber-lang/vsc-amber-extensions

@Mte90 Mte90 closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants