First draft of migrations #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baev
requested changes
May 2, 2017
| /** | ||
| * Allure labels utils. | ||
| */ | ||
| public final class Allure1Annotations { |
| } | ||
|
|
||
| @SuppressWarnings("PMD") | ||
| private void doNothing() { |
There was a problem hiding this comment.
It's created to avoid findbug analysis issue.
I can replace it by anotation @SuppressFBWarnings("...") in com.google.code.findbugs:annotations:3.0.0
| @@ -0,0 1,21 @@ | |||
| package ru.yandex.qatools.allure.annotations; | |||
|
|
|||
| import java.lang.annotation.*; | |||
allure-java-migrations/build.gradle
Outdated
| } | ||
|
|
||
| configurations { | ||
| provided |
allure-java-migrations/build.gradle
Outdated
| compile project(':allure-java-commons') | ||
|
|
||
| compile 'org.aspectj:aspectjrt' | ||
| compile 'org.allurefw:allure1-model' |
There was a problem hiding this comment.
can we avoid using this dependency?
| private final Object[] args; | ||
|
|
||
|
|
||
| public Allure1Annotations(final Object target, final MethodSignature signature, final Object... args) { |
There was a problem hiding this comment.
That feels like you need to split this utility class into two different classes - one that extracts data and the other that creates labels etc
| /** | ||
| * Some utils that help process steps and attachments names and titles. | ||
| */ | ||
| public final class Allure1AspectUtils { |
baev
approved these changes
May 4, 2017
|
|
||
| private final Object[] args; | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.