Upgrade to JBehave 4.4 #331
Conversation
| @@ -134,7 134,7 @@ public void beforeExamples(final List<String> steps, final ExamplesTable table) | |||
| } | |||
|
|
|||
| @Override | |||
| public void example(final Map<String, String> tableRow) { | |||
There was a problem hiding this comment.
Good job, JBehave. Breaking changes in minor release 👏 😢
There was a problem hiding this comment.
they are not really breaking changes, the methods are deprecated, so to be on the safe side it's better to switch to non-deprecated API
There was a problem hiding this comment.
they are not really breaking changes, the methods are deprecated, so to be on the safe side it's better to switch to non-deprecated API
I don't like this change then. Now people should upgrade to the latest JBehave to use upcoming allure-jbehave:2.11.0
There was a problem hiding this comment.
it's up to you: to upgrade or not to upgrade such dependencies, in theory minor version change should be fully safe for users, but who knows how much users are dependent on particular implementations
There was a problem hiding this comment.
It's ok to upgrade the dependency. But I'd like to continue using of deprecated API at least for a some time, to give users an opportunity use older JBehave versions with latest Allure integration for a while
There was a problem hiding this comment.
ok, for now I've updated PR to just bump JBehave version
valfirst
force-pushed
the
upgrade-to-jbehave-4-4
branch
from
67f7c7e
to
92ff1bd
Compare
|
@valfirst thanks! |
Checklist