-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RPC types Add temporary bare Provider
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@prestwich weren't we going to drop wasm? that's the only place the CI is failing and we need |
we were discussing it, but i think we can keep it as long as we do the |
Evalir
force-pushed
the
evalir/add-rpc-types
branch
from
October 31, 2023 20:45
d93b34a
to
48a79f6
Compare
Unfortunately deserialized untagged unions with RawValue does not work: serde-rs/json#497
providers: Add temporary bare `Provider`
Evalir
changed the title
feat: add RPC types
feat: add RPC types Add temporary bare Nov 1, 2023
Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move over RPC types from reth's rpc-types crate.
Solution
Port RPC types over.
PR Checklist