Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RPC types Add temporary bare Provider #13

Merged
merged 31 commits into from
Nov 1, 2023
Merged

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Oct 30, 2023

Motivation

Move over RPC types from reth's rpc-types crate.

Solution

Port RPC types over.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@Evalir
Copy link
Contributor Author

Evalir commented Oct 31, 2023

@prestwich weren't we going to drop wasm? that's the only place the CI is failing and we need getrandom for a few types here

@prestwich
Copy link
Member

we were discussing it, but i think we can keep it as long as we do the spawn & ?Send conditional compilations. The rest of tokio that we use is wasm-capable

@Evalir Evalir force-pushed the evalir/add-rpc-types branch from d93b34a to 48a79f6 Compare October 31, 2023 20:45
@Evalir Evalir changed the title feat: add RPC types feat: add RPC types Add temporary bare Provider Nov 1, 2023
@Evalir Evalir merged commit 36b4a50 into main Nov 1, 2023
17 checks passed
@gakonst gakonst deleted the evalir/add-rpc-types branch November 5, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants