I have found SQL security issues elsewhere, and I will fix them together

Do I need to deal with SQL security issues in all these places @KomachiSion

other mapper class all have this problem

For pagination parameters, basically no ? are retained to avoid SQL security problem

These implementation all has problem, we should add a new issue to mark the problem and fix them together.

First to fix this issue, and please @publicize-y to create new issue to describe this after PR merged.

@publicize-y CI and IT can't pass, maybe some check can't pass.

And more thing which you shou add some UT for your change codes.

ok，i get it

@publicize-y CI and IT can't pass, maybe some check can't pass.

And more thing which you shou add some UT for your change codes.

There is already a unit test, do I need to write another one

@publicize-y CI and IT can't pass, maybe some check can't pass.
And more thing which you shou add some UT for your change codes.

There is already a unit test, do I need to write another one

and the logic seems to not require modification

@publicize-y CI and IT can't pass, maybe some check can't pass.
And more thing which you shou add some UT for your change codes.

There is already a unit test, do I need to write another one

and the logic seems to not require modification

If UT has exist and covered your method, UT might can't pass, because your code change the return value for this method.

@publicize-y CI and IT can't pass, maybe some check can't pass.
And more thing which you shou add some UT for your change codes.

There is already a unit test, do I need to write another one

and the logic seems to not require modification

If UT has exist and covered your method, UT might can't pass, because your code change the return value for this method.

Ignore it , I found you has change the UT case.

plugin/datasource/src/test/java/com/alibaba/nacos/plugin/datasource/impl/mysql/ConfigInfoMapperByMySqlTest.java

CI still not pass

you can use mvn -B clean package apache-rat:check findbugs:findbugs -DskipTests -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn do check in local env first.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.58%. Comparing base (a7d9ef2) to head (3390c0e).
Report is 8 commits behind head on develop.

@@              Coverage Diff              @@
##             develop   #11883       /-   ##
=============================================
  Coverage      68.42%   68.58%    0.15%     
- Complexity      8989     9031       42     
=============================================
  Files           1239     1239              
  Lines          40573    40613       40     
  Branches        4317     4322        5     
=============================================
  Hits           27761    27853       92     
  Misses         10821    10760      -61     
- Partials        1991     2000        9