Develop fill ut common #11335
Merged
Develop fill ut common #11335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11335 /- ##
=============================================
Coverage 58.33% 60.38% 2.04%
- Complexity 5750 5832 82
=============================================
Files 885 883 -2
Lines 27356 26827 -529
Branches 2890 2770 -120
=============================================
Hits 15958 16199 241
Misses 10173 9507 -666
Partials 1225 1121 -104
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lowezheng
added a commit
to lowezheng/nacos
that referenced
this pull request
Nov 12, 2023
* develop: (137 commits) Develop refactor topn (alibaba#11352) Develop fill ut common (alibaba#11335) Optimize MapperManager (alibaba#11195) Simplify the validate method for serviceinfo (alibaba#11312) add startup conditions (alibaba#11305) Fix some typos (alibaba#11269) fix: rename tar name (alibaba#11281) 优化节点显示，添加mode (alibaba#11275) [ISSUE alibaba#11253]To fix the triggering of the listener upon failover con… (alibaba#11254) Add description for new plugin. (alibaba#11268) Upgrade to 2.3.0-BETA. (alibaba#11262) [ISSUE alibaba#11255]Update PathEncoderManagerTest#testEncodeWithNonExistOs. (alibaba#11256) Fill ut for common module (alibaba#11247) Optimize ThreadPoolManager (alibaba#11206) Fix npe when setup ack response in GrpcClient (alibaba#11210) [ISSUE#11192] batchRegisterInstance add recalculateRevision (alibaba#11232) feat(alibaba#11236): Remove invalid assertion in com.alibaba.nacos.config.server.service.ConfigCacheService#dumpChange. (alibaba#11237) feat(11115): http support cas publish. (alibaba#11120) [ISSUE alibaba#11231]Optimize the handleSpringBinder method in PropertiesUtil. (alibaba#11240) ISSUE alibaba#11212 (alibaba#11213) ... # Conflicts: # console-ui/package-lock.json # console-ui/package.json # console-ui/src/pages/Login/Login.jsx # core/src/main/java/com/alibaba/nacos/core/listener/StartingApplicationListener.java # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.