Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2 msgpack endpoints for browsers #210

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

jasonpaulos
Copy link
Contributor

This properly exposes msgpack responses in the browser for v2 endpoints such as /v2/transactions/pending.

Closes #209.

Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚢

@jasonpaulos jasonpaulos merged commit 71a2dc1 into develop Sep 22, 2020
@jasonpaulos jasonpaulos deleted the jasonpaulos/fix-browser-msgpack branch September 22, 2020 13:11
This was referenced Sep 22, 2020
bricerisingalgorand pushed a commit to bricerisingalgorand/js-algorand-sdk that referenced this pull request Jul 20, 2021
Fix a typo and make it clearer that results with an amount equal to the value are excluded.
This is because usually "min" and "max" include the value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Found work] Msgpack responses are undefined in browsers
2 participants