fix: focus detached input on iOS (#653) #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salomvary
force-pushed
the
fix-focus-on-ios
branch
from
3763dcc to
dba1852
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7baccd2:
|
Haroenv
approved these changes
Jan 16, 2024
francoischalifour
approved these changes
Jan 16, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the focusing code was in a requestAnimationFrame to ensure it wasn't blocking other potentially more important browser work. However, this causes the input not to get focused on iOS, as the focus call isn't related to a user action anymore.
As the
requestAnimationFramedoesn't have any real use case, removing it doesn't break any experiences, nor tests.A test can be written by ensuring the input is immediately focused, not delayed in any way.
fixes #653