-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump glutin to 0.29.0 #6079
Bump glutin to 0.29.0 #6079
Conversation
6b774ad
to
8a53967
Compare
e6ea4ab
to
961c562
Compare
961c562
to
6c9fa5c
Compare
6c9fa5c
to
0bc5047
Compare
2a60dbe
to
2b03e4e
Compare
@sshock could you verify that tab issue you've mentioned in winit rust-windowing/winit#2238 gets resolved with this patch? I'm not sure what to look for myself on macOS for that... |
d3bd9a6
to
6b32bca
Compare
CHANGELOG.md
Outdated
|
||
### Changed | ||
|
||
- The `--help` output was reworked with a new colorful syntax | ||
- OSC 52 is now disabled on unfocused windows | ||
- `SpawnNewInstance` no longer inherits initial `--command` | ||
- Client side decorations should have proper text rendering now on Wayland | ||
- Search bar is now respecting cursor thickness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this should be fixed in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a part of IME commit.
CHANGELOG.md
Outdated
- Incorrect built-in glyphs for `U 2567` and `U 2568` | ||
- Cursor not hiding on GNOME Wayland | ||
- Font having different scale factor after monitor powering off/on on X11 | ||
- Wrong mouse input when opening a new tabbed window on macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than describing the mouse part here, I'd instead mention that the entire window content was offset. It affected rendering too, even with no mouse usage.
Yep, it's working! |
35b7ef5
to
accad57
Compare
a3a26dc
to
0509425
Compare
df75b81
to
15a9dc7
Compare
15a9dc7
to
8fe31e8
Compare
8fe31e8
to
c5a0fd0
Compare
@chrisduerr I've removed IME commit for now and implemented it like we had before. Will rewrite it and send separately.
MSRV issue got resolved. |
15d0236
to
190ba88
Compare
alacritty/src/main.rs
Outdated
let exit_code = match result { | ||
Ok(code) => code, | ||
Err(err) => { | ||
eprintln!("Error: {}", err); | ||
EXIT_FAILURE | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother with exit codes and all that stuff when Err(err)
is mapped to an exit code anyway? Just so we don't print the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to propagate the error code from the event loop somehow, since now run_return
will return non zero code in case of failures.
I basically wanted to indicate an error with non zero exit status nothing more. If you have an idea on how to handle that more reliably let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not return the actual error? That seems to be the sensible choice to me.
1f3136c
to
826ab98
Compare
826ab98
to
6000cc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about returning a Result.
6df4a48
to
1e90ade
Compare
@@ -62,7 62,7 @@ use crate::event::{Event, Processor}; | |||
#[cfg(target_os = "macos")] | |||
use crate::macos::locale; | |||
|
|||
fn main() { | |||
fn main() -> Result<(), Box<dyn Error>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only ever gotten extremely poor results from doing this. I don't think it's a great idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine, like it'll print error? At least that's how I've parsed your lets return Result
, but now I see that you wanted to return it from run_return
, but you can't do that.
I'm not sure that this is any different than then println
and then exit
that what it should do anyway, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think my main issue with last time I tried it is that you don't get any backtrace by doing this. Which should be fine in our case since we were just using println
anyway.
alacritty/src/event.rs
Outdated
// Stash the error and exit with non-zero code. | ||
*loop_error.lock().unwrap() = result.into(); | ||
*control_flow = ControlFlow::ExitWithCode(1); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait can we not just exit with any generic result, which is then returned from the closure?! That's kinda garbage.
Let's maybe just print the error directly inside the run_return
, then exit upwards with just any random error text?
I definitely don't want to throw mutexes at a silly one-off error that can only happen right before the event loop crashes anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have the ability to return from winit's run_return
with any type parameter, but this should be fine for now.
@@ -62,7 62,7 @@ use crate::event::{Event, Processor}; | |||
#[cfg(target_os = "macos")] | |||
use crate::macos::locale; | |||
|
|||
fn main() { | |||
fn main() -> Result<(), Box<dyn Error>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think my main issue with last time I tried it is that you don't get any backtrace by doing this. Which should be fine in our case since we were just using println
anyway.
Fixes alacritty#6239. Fixes alacritty#5975. Fixes alacritty#5876. Fixes alacritty#5767. Fixes alacritty#4484. Fixes alacritty#3139.
700bcc1
to
bda4889
Compare
Fixes #5975.
Fixes #5767.