Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPOPLPUSH not supported when use envoy as a proxy #489

Open
bighunter513 opened this issue Jun 5, 2024 · 4 comments
Open

RPOPLPUSH not supported when use envoy as a proxy #489

bighunter513 opened this issue Jun 5, 2024 · 4 comments

Comments

@bighunter513
Copy link

when I connect to a proxy use envoy to aws redis cluster, I encountered the problem:
Redis Error [error: {:error, {%Redix.Error{message: "unsupported command 'RPOPLPUSH'"}

I checked redis doc,
it suggest use LMOVE to replace LPOPRPUSH , and I tried out it was ok behind envoy
so can you add LMOVE support later ?

`
redis-cli -p 7480 ## which connect to envoy 1.30

127.0.0.1:7480> RPUSH {list}:list1 "one"
(integer) 1
127.0.0.1:7480> RPUSH {list}:list1 "two"
(integer) 2
127.0.0.1:7480> RPUSH {list}:list1 "three"
(integer) 3
127.0.0.1:7480> LMOVE {list}:list1 {list}:list2 LEFT RIGHT
"one"
127.0.0.1:7480> LMOVE {list}:list1 {list}:list2 RIGHT LEFT
"three"`

@ananthakumaran
Copy link
Collaborator

Since this was not supported before 6.2, we would have to drop support for <6.2. I don't know how many users still use <6.2.

@bighunter513
Copy link
Author

Since this was not supported before 6.2, we would have to drop support for <6.2. I don't know how many users still use <6.2.

maybe add a option to let user choose ? or use tag version ?

@ananthakumaran
Copy link
Collaborator

maybe add a option to let user choose ?

This may be better, I am open to a PR

Also, can you expand a bit on the problem. is it an issue on envoy or redis itself doesn't support it?

@bighunter513
Copy link
Author

maybe add a option to let user choose ?

This may be better, I am open to a PR

Also, can you expand a bit on the problem. is it an issue on envoy or redis itself doesn't support it?

Redis doesn't support it, you can check this doc https://redis.io/docs/latest/commands/rpoplpush/

As of Redis version 6.2.0, this command is regarded as deprecated.
It can be replaced by LMOVE with the RIGHT and LEFT arguments when migrating or writing new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants