Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Redshift: Auto conversion of src/main/java to Kotlin #38803

Merged
merged 1 commit into from
May 31, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented May 31, 2024

What

Silencing warnings, and suppressed few findBugs because base classes in CDK have nullable types.

Used localCdk true for conversion, there are significant changes adding entropy so keeping the cdk version as-is.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 3:56pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label May 31, 2024
Copy link
Contributor Author

gisripa commented May 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa changed the title redshift-auto-kotlin Destination Redshift: Auto conversion of src/main/java to Kotlin May 31, 2024
@gisripa gisripa force-pushed the gireesh/05-30-redshift-auto-kotlin branch from 8dc2b28 to 605677c Compare May 31, 2024 01:51
@gisripa gisripa marked this pull request as ready for review May 31, 2024 01:53
@gisripa gisripa requested a review from a team as a code owner May 31, 2024 01:53
@gisripa gisripa force-pushed the gireesh/05-30-redshift-auto-kotlin branch from 605677c to 4513c56 Compare May 31, 2024 03:44
@gisripa gisripa force-pushed the gireesh/05-30-redshift-auto-kotlin branch from 4513c56 to 7026e8b Compare May 31, 2024 15:52
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 31, 2024
@gisripa gisripa merged commit de16005 into master May 31, 2024
31 checks passed
@gisripa gisripa deleted the gireesh/05-30-redshift-auto-kotlin branch May 31, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants