Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Redshift - Reorder Spec options #34014

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

jbfbell
Copy link
Contributor

@jbfbell jbfbell commented Jan 8, 2024

Update the order of the spec options for destination redshift such that they're all in the connection group.
Screenshot 2024-01-08 at 9 42 53 AM

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 5:52pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@jbfbell jbfbell marked this pull request as ready for review January 8, 2024 18:01
@jbfbell jbfbell requested a review from a team as a code owner January 8, 2024 18:01
@jbfbell
Copy link
Contributor Author

jbfbell commented Jan 8, 2024

closes #33985

@jbfbell jbfbell linked an issue Jan 8, 2024 that may be closed by this pull request
@jbfbell jbfbell merged commit 8b00460 into master Jan 8, 2024
27 of 30 checks passed
@jbfbell jbfbell deleted the joseph.bell/33985/spec-order branch January 8, 2024 19:54
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Option to Disable Final Table Creation down the spec
3 participants