Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package build and publish workflow #658

Merged
merged 1 commit into from
Apr 13, 2022
Merged

add package build and publish workflow #658

merged 1 commit into from
Apr 13, 2022

Conversation

JJJ000
Copy link
Collaborator

@JJJ000 JJJ000 commented Apr 12, 2022 •
edited
Loading

Description of changeset:

  1. add task name to main workflow
  2. add Build and publish workflow to pypi

by following: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

Test Plan:
[x] verfiy on with test Test PyPI

@csharplus @etr2460

@JJJ000 JJJ000 changed the title add workflow add package build and publish workflow Apr 12, 2022
@JJJ000
Copy link
Collaborator Author

JJJ000 commented Apr 12, 2022

@etr2460 when you get a chance, could you generate two tokens for both Test PyPI, PyPI) and add in repo settings?

csharplus
csharplus approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@csharplus csharplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The build didn't go through yet.

@JJJ000 JJJ000 merged commit baad933 into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csharplus csharplus csharplus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJJ000 @csharplus