-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting binding address #708
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #708 /- ##
==========================================
Coverage 95.78% 95.85% 0.06%
==========================================
Files 23 23
Lines 1686 1712 26
Branches 194 198 4
==========================================
Hits 1615 1641 26
Misses 46 46
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Hmm, there's a weird test failure... Otherwise, looks good. |
Also, if you'd like to try and upgrade pytest, there is a workaround mentioned in this comment I've yet to try: pytest-dev/pytest-forked#67 (comment) |
This test failure seems to be a pytest internal error and happens on macos only. All tests work well on my machine and other linux ci action. I don't have a macos environment to debug it... Maybe it is related to pytest-dev/pytest-forked#78. Traceback shows the same "Bad file descriptor" message when running action with coverage disabled. |
- set bind address in test_start_runserver to 0.0.0.0
The test passed after setting bind address to 0.0.0.0. 19e89ad Have no idea why binding to localhost in this test causes pytest internal error on macos. |
What do these changes do?
Add a new option
--bind
to set the binding address. Keep--host
parameter to be used for overriding bind address when referencing static files.Are there changes in behavior for the user?
Related issue number
Fixes #449
Checklist