Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation instructions #28

Merged
merged 2 commits into from
Sep 27, 2019
Merged

update installation instructions #28

merged 2 commits into from
Sep 27, 2019

Conversation

mazzz1y
Copy link
Contributor

@mazzz1y mazzz1y commented Jul 7, 2019

I've updated "Print the full command before running it" function to avoid errors on command piping

Example:

kubectl -n default create secret generic credentials --from-file=/tmp/credentials.json --dry-run -o yaml | kubectl apply -f -

Throws error:

error: error parsing STDIN: error converting YAML to JSON: yaml: line 2: mapping values are not allowed in this context

Because kubectl -n default create secret generic... included onto the pipe, but should not

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mazzz1y
Copy link
Contributor Author

mazzz1y commented Jul 7, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 7, 2019
@ahmetb
Copy link
Owner

ahmetb commented Jul 8, 2019

Can't we just do echo >&2 instead? That way I assume it wouldn't be included in what's passed to the pipe?

@ahmetb
Copy link
Owner

ahmetb commented Jul 8, 2019

That worked?

@mazzz1y
Copy link
Contributor Author

mazzz1y commented Jul 8, 2019

Yes, it works. It prints command in terminal without including to pipe. Good idea.

I've updated my branch

@bitti
Copy link

bitti commented Sep 26, 2019

I just wanted to open a PR with the same change, when I saw there is already one ;) Diagnostic messages shouldn't be printed to stdout. Why isn't it merged yet?

@ahmetb ahmetb merged commit 92c4953 into ahmetb:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants