-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update installation instructions #28
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Can't we just do |
That worked? |
Yes, it works. It prints command in terminal without including to pipe. Good idea. I've updated my branch |
I just wanted to open a PR with the same change, when I saw there is already one ;) Diagnostic messages shouldn't be printed to stdout. Why isn't it merged yet? |
I've updated "Print the full command before running it" function to avoid errors on command piping
Example:
kubectl -n default create secret generic credentials --from-file=/tmp/credentials.json --dry-run -o yaml | kubectl apply -f -
Throws error:
Because
kubectl -n default create secret generic...
included onto the pipe, but should not