Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias's uncovering fix #10

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Alias's uncovering fix #10

merged 2 commits into from
Jun 21, 2018

Conversation

freele
Copy link
Contributor

@freele freele commented Jun 18, 2018

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@freele
Copy link
Contributor Author

freele commented Jun 18, 2018

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@ahmetb
Copy link
Owner

ahmetb commented Jun 18, 2018

This looks good but I don't understand how it's any different. What's the issue here?

@freele
Copy link
Contributor Author

freele commented Jun 19, 2018

All good, just misspells.
before: func kubectl(){ .
after: function kubectl() { .
both keyword and space between () { matter

@ahmetb
Copy link
Owner

ahmetb commented Jun 19, 2018

In that case can we still keep it single line? If so, please make the change.

Thanks for discovering this.

@freele
Copy link
Contributor Author

freele commented Jun 21, 2018

fixed

@ahmetb ahmetb merged commit e0454df into ahmetb:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants