feat: seed with service #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hajbo
requested changes
Oct 21, 2023
Comment on lines
20
to
30
| await usersService.createUser({ | ||
| email: faker.internet.email(), | ||
| username: faker.internet.userName(), | ||
| password: await Bun.password.hash(faker.internet.password()), | ||
| bio: faker.lorem.text(), | ||
| image: faker.image.imageUrl(), | ||
| }; | ||
| console.log('Upserting user:', data); | ||
| password: faker.internet.password(), | ||
| }); | ||
|
|
||
| await db.insert(users).values(data); | ||
| console.log('User upserted'); | ||
| // Update the user's bio and image | ||
| await usersService.updateUser(i, { | ||
| bio: faker.lorem.paragraph(), | ||
| image: faker.internet.avatar(), | ||
| }); |
There was a problem hiding this comment.
I think we should be able to create a user with all attributes. It's just that the frontend won't send the two optional keys in the registration request
Comment on lines
78
to
83
| async findAll() { | ||
| const users = await this.repository.findAll(); | ||
| return await Promise.all( | ||
| users.map((user) => this.generateUserResponse(user)), | ||
| ); | ||
| } |
There was a problem hiding this comment.
I see two problems with this:
- It'll generate a valid token for ALL users, which is probably not a good thing to do regardless if it's exposed in an API or not
- Although the spec doesn't talk about a functionality like this, but I think the returned data format should be changed. Instead of a list of singular user objects (
{user: {...}}[]) it could be one plural users object, e.g.{users: [user1, user2]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests treating the seeder as a service controller rather than as a direct database manipulator.
Having the seeding device interact with the service layer achieves 2 goals:
PR Checklist (Please do not remove)
type(scope): descriptionortype: descriptionformatReference an issue or discussion where the feature or changes have been previously discussedAdd a failing test that passes with the changes introduced in this PR, or explain why it's not feasibleAdd documentation for the feature or changes introduced in this PR to the docs; you can run them withbun docs