This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
set Accept header to */* if raw param is set #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (undocumented) raw parameter says to me, "I want to get arbitrary non-JSON data from this URL; please wrap it for me." However if we explicitly set the Accept header to 'application/json' we might get a 406 back from the external service. If the user explicitly set the raw param, it makes sense to accept everything, right?
|
Good call! Mind adding a test? |
dtao
added a commit
to dtao/jsonp
that referenced
this pull request
Dec 23, 2013
|
Now thinking that it should pass the |
|
Sure, I guess that makes sense. In that case maybe you could drop the |
|
My main concern there would be a) that I almost always use my browser to test API calls, which request Also, I'd want to be confident that doesn't (further) open up any XSS vulnerabilities. |
|
OK, fine by me then. Not that you needed my approval ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (undocumented) raw parameter says to me, "I want to get arbitrary non-JSON data from this URL; please wrap it for me." However if we explicitly set the Accept header to 'application/json' we might get a 406 back from the external service. If the user explicitly set the raw param, it makes sense to accept everything, right?