Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka): add exporter #408

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(kafka): add exporter #408

wants to merge 4 commits into from

Conversation

gecube
Copy link
Collaborator

@gecube gecube commented Oct 9, 2024 •
edited by coderabbitai bot
Loading

Add kafka exporter:

https://strimzi.io/blog/2019/10/14/improving-prometheus-metrics/
https://strimzi.io/docs/0.14.0/full#assembly-kafka-exporter-configuration-deployment-configuration-kafka

Summary by CodeRabbit

  • New Features
    • Updated Kafka application chart version to 0.3.1.
    • Introduced a new kafkaExporter section in the Kafka resource configuration, allowing for flexible matching of consumer groups and topics using regular expressions.
    • Added resource requests and limits for CPU and memory in the kafkaExporter configuration.

These enhancements improve the configuration capabilities for users managing Kafka resources.

@gecube
feat(kafka): add exporter
a2519a5 
Signed-off-by: George Gaál <[email protected]>
@gecube gecube requested a review from kvaps as a code owner October 9, 2024 15:15
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2024 •
edited
Loading

Walkthrough

The pull request includes updates to two files related to the Kafka application. The Chart.yaml file has its version number incremented from 0.3.0 to 0.3.1, while the kafka.yaml file introduces a new section for kafkaExporter within the spec, which includes three fields: groupRegex, topicRegex, and resources. The resources field specifies CPU and memory requests and limits, enhancing the configuration options for the Kafka exporter.

Changes

File Change Summary
packages/apps/kafka/Chart.yaml Version updated from 0.3.0 to 0.3.1. Application version remains unchanged at 3.7.0.
packages/apps/kafka/templates/kafka.yaml New section kafkaExporter added in spec, with fields groupRegex: ".*", topicRegex: ".*", and resource specifications for CPU and memory.

Poem

In the land of Kafka, changes take flight,
A version updated, oh what a sight!
With regex patterns, we now can explore,
Consumer groups and topics, we’ll match even more!
Hopping with joy, we celebrate this day,
For flexibility blooms in a wonderful way! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9e29401 and b065dc5.

📒 Files selected for processing (1)
  • packages/apps/kafka/templates/kafka.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/apps/kafka/templates/kafka.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

themoriarti
themoriarti approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I add resource request and limiting for kafka exporter.

themoriarti
themoriarti approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themoriarti themoriarti themoriarti approved these changes

@kvaps kvaps Awaiting requested review from kvaps kvaps is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gecube @themoriarti