Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ingress for grafana and alerta #401

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix ingress for grafana and alerta #401

merged 1 commit into from
Oct 7, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Oct 7, 2024 •
edited by coderabbitai bot
Loading

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

  • New Features

    • Enhanced TLS management with the addition of a cluster issuer annotation for Alerta.
    • Introduced a new environment variable for Alerta API key management.
    • Improved Telegram integration with dynamic environment variable configuration in Alerta.

  • Bug Fixes

    • Corrected host value formatting in Ingress rules for both Alerta and Grafana.
    • Fixed indentation issues in Grafana's YAML configuration for better readability.

@kvaps kvaps merged commit 15001dc into main Oct 7, 2024
@kvaps kvaps deleted the fix-ingress-grafana-alerta branch October 7, 2024 19:12
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve updates to the Kubernetes YAML configurations for both the Alerta and Grafana applications. For Alerta, a new annotation for TLS certificate management was added, along with an environment variable for API key handling. The Ingress rules were reformatted for clarity. In Grafana, modifications were made to the root_url and host specifications to ensure consistent formatting, and indentation issues were corrected. These updates enhance configuration clarity and maintain proper YAML structure.

Changes

File Path Change Summary
packages/extra/monitoring/templates/alerta/alerta.yaml - Added annotation cert-manager.io/cluster-issuer: letsencrypt-prod to Ingress.
- Added environment variable ALERTA_API_KEY to Deployment.
- Updated Secret retrieval logic for API key decoding.
packages/extra/monitoring/templates/grafana/grafana.yaml - Updated root_url and host specifications for consistent formatting.
- Corrected indentation in the tls section.
- Conditional inclusion of ingressClassName and acme.cert-manager.io/http01-ingress-class annotations remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Ingress
    participant Alerta
    participant Grafana

    User->>Ingress: Request for Alerta
    Ingress->>Alerta: Forward request
    Alerta->>Ingress: Response
    Ingress->>User: Return response

    User->>Ingress: Request for Grafana
    Ingress->>Grafana: Forward request
    Grafana->>Ingress: Response
    Ingress->>User: Return response
Loading

🐰 "In the land of YAML, we make it bright,
With keys and values, all aligned just right.
Alerta's secrets now shine with glee,
While Grafana's hosts dance in harmony.
Oh, the joy of clean code, a rabbit's delight,
Hopping through changes, everything feels right!" 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

chumkaska pushed a commit to chumkaska/cozystack that referenced this pull request Oct 15, 2024
@kvaps @agaenix
Fix ingress for grafana and alerta (aenix-io#401)
a038a33 
Signed-off-by: Andrei Kvapil <[email protected]>

Signed-off-by: Andrei Kvapil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kvaps